Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP] l10n_it_ricevute_bancarie: Issue riba without admin permissions #3352

Merged
merged 1 commit into from
Jun 13, 2023
Merged

[14.0][IMP] l10n_it_ricevute_bancarie: Issue riba without admin permissions #3352

merged 1 commit into from
Jun 13, 2023

Conversation

odooNextev
Copy link
Contributor

@matteoopenf
Copy link
Contributor

merge?

GSLabIt
GSLabIt reviewed Jun 8, 2023
View reviewed changes
l10n_it_ricevute_bancarie/wizard/wizard_riba_issue.py Outdated
action = act_obj.browse(action_id)
action_vals = action.read()[0]
action_xml_id = act_obj.browse(action_id).xml_id
action_vals = self.env["ir.actions.act_window"]._for_xml_id(action_xml_id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

credo che tutta questa parte:

l10n-italy/l10n_it_ricevute_bancarie/wizard/wizard_riba_issue.py

Lines 139 to 150 in a470eb9

mod_obj = self.env["ir.model.data"]
act_obj = self.env["ir.actions.act_window"]
action = mod_obj.get_object_reference(
"l10n_it_ricevute_bancarie", "distinta_riba_action"
)
view = mod_obj.get_object_reference(
"l10n_it_ricevute_bancarie", "view_riba_distinta_form"
)
action_id = action and action[1] or False
action_xml_id = act_obj.browse(action_id).xml_id
action_vals = self.env["ir.actions.act_window"]._for_xml_id(action_xml_id)
action_vals["views"] = [(view and view[1] or False, "form")]

possa essere sostituita con una singola chiamata:

action_vals = self.env["ir.actions.act_window"]._for_xml_id("l10n_it_ricevute_bancarie.distinta_riba_action")

@odooNextev odooNextev force-pushed the 14.0-imp-l10n_it_ricevute_bancarie branch from a470eb9 to 4a6913e Compare June 8, 2023 08:33
@matteoopenf
Copy link
Contributor

@GSLabIt ci siamo?

@matteoopenf
Copy link
Contributor

@GSLabIt ci siamo?

visto ora che si sono rotti i test

@francesco-ooops
Copy link
Contributor

@GSLabIt ci siamo?

visto ora che si sono rotti i test

I test son rotti da #3366 , ci sta lavorando @odooNextev

@francesco-ooops
Copy link
Contributor

@odooNextev rebase?

@odooNextev odooNextev changed the title [IMP]l10n_it_ricevute_bancarie: Issue riba without admin permissions [14.0][IMP]l10n_it_ricevute_bancarie: Issue riba without admin permissions Jun 12, 2023
@odooNextev odooNextev changed the title [14.0][IMP]l10n_it_ricevute_bancarie: Issue riba without admin permissions [14.0][IMP] l10n_it_ricevute_bancarie: Issue riba without admin permissions Jun 12, 2023
@odooNextev odooNextev force-pushed the 14.0-imp-l10n_it_ricevute_bancarie branch from 4a6913e to 232b4b8 Compare June 12, 2023 07:58
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@francesco-ooops
Copy link
Contributor

@OCA/local-italy-maintainers merge?

@tafaRU
Copy link
Member

tafaRU commented Jun 13, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-3352-by-tafaRU-bump-patch, awaiting test results.

This was referenced Jun 13, 2023
Closed
Closed
@OCA-git-bot OCA-git-bot merged commit 3c0b844 into OCA:14.0 Jun 13, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 66c4308. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SicurSam SicurSam SicurSam approved these changes

@matteoopenf matteoopenf matteoopenf approved these changes

@GSLabIt GSLabIt GSLabIt approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 no issue needed ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@odooNextev @matteoopenf @francesco-ooops @OCA-git-bot @tafaRU @GSLabIt @SicurSam @matteonext